Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French Translation #252

Merged
merged 39 commits into from
Jan 13, 2024
Merged

Conversation

niltied
Copy link
Contributor

@niltied niltied commented Jan 13, 2024

Hi @hossainemruz,

I saw your big update of Toha Guide. For this MR, I push my latest translation before your upgrade (only French doc).
I will check your latest change to update French translation next time.

Regard,

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niltied! Can you please fix the shortcode example as pointed out by the comment below? Please, check the following preview URL to verify that they are rendered correctly:
https://deploy-preview-252--toha-guides.netlify.app/fr/posts/shortcodes/

content/posts/shortcodes/index.fr.md Outdated Show resolved Hide resolved
@hossainemruz
Copy link
Member

@niltied Just to notify you that I have added/updated few more guides in this PR:
#254

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site does not build due to some missing /* in the shortcode guide. Can you please fix them?

content/posts/shortcodes/index.fr.md Outdated Show resolved Hide resolved
content/posts/shortcodes/index.fr.md Outdated Show resolved Hide resolved
Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niltied for the hard works! Looks good to me. 🚀

@hossainemruz hossainemruz merged commit 615f84a into hugo-toha:main Jan 13, 2024
3 of 5 checks passed
@niltied niltied deleted the nico-16122023 branch January 19, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants