Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes on mermaid guide #269

Closed
wants to merge 30 commits into from
Closed

Conversation

niltied
Copy link
Contributor

@niltied niltied commented Feb 2, 2024

Minor fixes and addition customize theme for mermaid graph

@hossainemruz
Copy link
Member

@niltied can you please rebase your fork against upstream? Also, please add a proper title to the PR.

@niltied niltied changed the title Nico 19012024 Several fixes on mermaid guide Feb 3, 2024
@niltied
Copy link
Contributor Author

niltied commented Feb 3, 2024

@niltied can you please rebase your fork against upstream? Also, please add a proper title to the PR.

Hi @hossainemruz,

The title has now been changed. But there is still a problem on GitGraph on the Mermaid Guide (all language version). It does not work. I think it comes from the options block. I did not find these options in the Mermaid.js documentation. Maybe it's deprecated. We would have to delete it to see, and maybe replace with an equivalent %%{ init: { } %%} block.

@niltied niltied closed this Feb 3, 2024
@niltied niltied deleted the nico-19012024 branch February 3, 2024 07:14
@niltied niltied restored the nico-19012024 branch February 3, 2024 07:14
@niltied niltied deleted the nico-19012024 branch February 3, 2024 07:14
@niltied niltied restored the nico-19012024 branch February 3, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants