Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little fix from PR #938 #299

Merged
merged 80 commits into from
May 31, 2024
Merged

Little fix from PR #938 #299

merged 80 commits into from
May 31, 2024

Conversation

niltied
Copy link
Contributor

@niltied niltied commented May 19, 2024

Hi @hossainemruz,

How are you ? I'm fine and congratulation for Toha v4.5.0 :). Nice release :)

I just saw in the Toha v4.5.0 release note that Umami is now supported. That's great ! But I saw some omissions in the documentation part related to Pull Request #938.

So I made improvements:

  • In the index.md file : Addition of acronyms and the Umami link at the start of the article.
  • In the index.fr.md file : French post is up to date with English post.
  • In the index.es.md file : Just added the Umami link at the beginning of the post. If possible @BernatBC, if you can update the Spanish article to be fully synchronized. It will be perfect.

That's all !

See you later,

@niltied niltied changed the title Little fix from MR #938 Little fix from PR #938 May 19, 2024
@BernatBC
Copy link
Member

Hi @niltied
Thank you for reminding me to translate this section to spanish. I've just added it.

Btw, I think we should add some method in order to know which translations are outdated. This could be a table indicating which pages are not updated or something else. What do you think @hossainemruz?

@niltied
Copy link
Contributor Author

niltied commented May 19, 2024

Hi @BernatBC,

You're welcome 👍🏻 . I agree with you about checking which translations are outdated. This must be necessary if we want to guarantee synchronization between the different translated docs.

@hossainemruz ?

@BernatBC
Copy link
Member

I've researched a little bit, and many open source projects use platforms like Weblate or Crowdin. Those are free for open source software, but probably we don't need that complex tools.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @niltied.

@hossainemruz hossainemruz merged commit bc3047b into hugo-toha:main May 31, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants