-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional skills breakdown modal #475
base: main
Are you sure you want to change the base?
Conversation
…n before collapsing
@fabiofenoglio Thank you for the PR. Look like a great idea. I will review soon. |
Hi @fabiofenoglio, I have started reviewing this PR. We need a better design for the breakdown popup. Probably, more simple but should be useful. I am thinking of removing the circular progress bar entirely. They don't provide any value. We can keep the horizontal progress bar but might make it optional. We need a simple and consistent view for multi-level items. Also, we must consider responsiveness of the popup. I might take few more weeks to come up with any mockup. |
001e28a
to
ddbb4bf
Compare
I'd like to propose a feature consisting in a detailed breakdown modal for the skills sections.
Description
This PR adds support for a "breakdown" parameter in the "skills" section.
If present, a dialog will popup when clicking on the skill, presenting a detailed skill breakdown.
The breakdown is highly customizable and can be nested at will.
Each entry of the skill breakdown can have optionally any combination of:
name
andsummary
logo
to display an imagepercentage
andcolor
to display a scaled-down circular progress, similar to the soft skill badges but much smallerprogress
to display the skill as a progress bar. IfprogressClass
is not provided, the class/color is automatically derived.breakdown
list allowing for arbitrary nestingexpandBreakdown
to optionally force the accordion of the children breakdown to be opened by defaultAs a side effect the following would be introduced:
circular-progress
component to allow reusing of the circular soft-skill badges in other places, supporting "sm" and "xs" versionsTest Evidence
Attaching a demo animation:
Here's a sample mixed and nested configuration:
Please let me know if you'd like the feature, if the parameters format is ok or if I forgot something like documentation.