Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add company and school logos #882

Merged
merged 17 commits into from
Feb 12, 2024
Merged

Add company and school logos #882

merged 17 commits into from
Feb 12, 2024

Conversation

BernatBC
Copy link
Member

@BernatBC BernatBC commented Feb 3, 2024

Issue

Fixes #871
Fixes #153

Description

Add logos for the following sections:

  • Education
  • Experiences

Test Evidence

image

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit 3eace57
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/65c6914e01dda500083b7e85
😎 Deploy Preview https://deploy-preview-882--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BernatBC
Copy link
Member Author

BernatBC commented Feb 3, 2024

This is how the experiences section will look:
image

@BernatBC BernatBC marked this pull request as ready for review February 3, 2024 09:43
@BernatBC BernatBC marked this pull request as draft February 3, 2024 09:47
@BernatBC
Copy link
Member Author

BernatBC commented Feb 3, 2024

I think now it's better:
image

@BernatBC BernatBC marked this pull request as ready for review February 3, 2024 10:10
@hossainemruz
Copy link
Member

The timeline should be scoped with the position not the company. You can have multiple positions within one company.

@BernatBC
Copy link
Member Author

BernatBC commented Feb 3, 2024

If you have multiple positions, the timeline looks like this: (hasn't changed)
image

@BernatBC
Copy link
Member Author

BernatBC commented Feb 3, 2024

Maybe is this better?
image

@BernatBC
Copy link
Member Author

BernatBC commented Feb 3, 2024

@hossainemruz now it's ready, you can ask for some changes if you wish

@niltied
Copy link
Contributor

niltied commented Feb 3, 2024

Great for me. Congrat @BernatBC ! 😀
Thank !

@niltied
Copy link
Contributor

niltied commented Feb 4, 2024

Re @hossainemruz & @BernatBC,

For later : don't forget too update experiences and educations guides (english, spanish and french) about the new field for experiences.yaml and education.yaml.

@BernatBC
Copy link
Member Author

BernatBC commented Feb 4, 2024

@niltied yesterday I made a Pull Request with these changes. PR: hugo-toha/guides/pull/272

@BernatBC
Copy link
Member Author

BernatBC commented Feb 9, 2024

On top, we can see a multiple-position company, and at the bottom a single-position company. Do you think that we can remove the single position layout and just use the multiple one for both cases?

image

@niltied
Copy link
Contributor

niltied commented Feb 9, 2024

Hi @BernatBC, it's fun. I can' wait to deploy this on my website !

@hossainemruz
Copy link
Member

hossainemruz commented Feb 9, 2024

On top, we can see a multiple-position company, and at the bottom a single-position company. Do you think that we can remove the single position layout and just use the multiple one for both cases?

Exactly that what I was thinking. Just need to be careful that we don't break any existing site. Also, sorry for keeping this PR pending. I am little busy with other stuff.

@BernatBC BernatBC marked this pull request as draft February 9, 2024 20:52
@BernatBC BernatBC marked this pull request as ready for review February 9, 2024 20:56
@hossainemruz hossainemruz enabled auto-merge (squash) February 12, 2024 07:25
@hossainemruz hossainemruz merged commit 11bddc3 into hugo-toha:main Feb 12, 2024
10 of 12 checks passed
@BernatBC BernatBC deleted the logos branch February 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants