Add tags in post cards from search results #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for toha-ci ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
After fixing both issues, now it's ready: |
…/toha into add-tags-search-results
|
Look like some CSS was not applied properly. This is what search result look like on your PR: This is what it is look like in the demo site.
|
|
I think that behaivour was already happening before the PR, but for some reason does not happen in my site. I'll check it soon |
Signed-off-by: hossainemruz <[email protected]>
|
Hi @BernatBC, I have found the issue that was causing CSS not applied properly and did a workaround. Things are good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When tags are enabled in post cards, they don't appear in the post search results.
Description
As you can see from the screenshot, if posts have different tags, the height is not adjusted at all. I've been looking how to get it fixed for a while, but I couldn't find the solution. If someone finds it, please tell me.
Test Evidence
on_card: true
on_card: false