Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add awesome icon in project cards #920

Merged
merged 3 commits into from
May 10, 2024

Conversation

BernatBC
Copy link
Member

@BernatBC BernatBC commented Apr 2, 2024

Issue

Fixes #910.

Description

Adds awesome icon when logo field is not an image.
We can change the icon color if needed.

Test Evidence

Toha card has logo: "fa-solid fa-hippo", while Jellyfin has: logo: /images/jellyfin.webp.
image
image

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for toha-ci ready!

Name Link
🔨 Latest commit 818eb17
🔍 Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/663e5f1fa889b20008183754
😎 Deploy Preview https://deploy-preview-920--toha-ci.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hossainemruz hossainemruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BernatBC

@hossainemruz hossainemruz merged commit 6f4e23a into hugo-toha:main May 10, 2024
10 of 12 checks passed
@niltied
Copy link
Contributor

niltied commented May 19, 2024

Hi @BernatBC,

Just test, it works fine ! Thank :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using FontAwesome icon for project card
3 participants