Fix google analytics feature

[joyao]

Issue

Fixes #955

Description

Fix google analytics feature based on official document.
https://gohugo.io/templates/embedded/#google-analytics

Test Evidence

[netlify]

✅ Deploy Preview for toha-ci ready!

Name	Link
🔨 Latest commit	1399825
🔍 Latest deploy log	https://app.netlify.com/sites/toha-ci/deploys/6746607090587a0008dcd0ef
😎 Deploy Preview	https://deploy-preview-989--toha-ci.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[hossainemruz]

Hi @joyao ! Thank you for the PR. Look like we are breaking compatibility here. With this change, following configuration will not work anymore:

services:
  googleAnalytics:
    ID: G-MEASUREMENT_ID

Do we want to force user to use analytics configuration from site.Params.analytics.services.google.id ? In that case, we should also provide a way do specify respectDoNotTrack under site.Params.analytics.services.google section.

[joyao]

Hi @joyao ! Thank you for the PR. Look like we are breaking compatibility here. With this change, following configuration will not work anymore:

services:
  googleAnalytics:
    ID: G-MEASUREMENT_ID

Do we want to force user to use analytics configuration from site.Params.analytics.services.google.id ? In that case, we should also provide a way do specify respectDoNotTrack under site.Params.analytics.services.google section.

I think both methods should be supported. I’ll fix it and thanks for your suggestion.

[joyao]

Hi @hossainemruz, under the "{{ with .google }}" condition, my original changes support both project custom settings and original settings as following, and have been tested.

analytics:
  enabled: true
  services:
    # Google Analytics
    google:
      id: G-H4LBG7NDFZ
      respectDoNotTrack: false

services:
  googleAnalytics:
    ID: G-H4LBG7NDFZ
privacy:
  googleAnalytics:
    disable: false
    respectDoNotTrack: true

So I just add the "respectDoNotTrack" part.

[jamesdeluk]

So what's the current workaround for getting analytics working, manually having these two files within layouts?

[joyao]

So what's the current workaround for getting analytics working, manually having these two files within layouts?

Hi @jamesdeluk, this PR hasn't been merged yet. If you want to have this fixed feature, you can merge my branch or fix these two files manually in your project.

[jamesdeluk]

Hi @jamesdeluk, this PR hasn't been merged yet. If you want to have this fixed feature, you can merge my branch or fix these two files manually in your project.

Thanks. And which is the best yaml config of the two above?

[joyao]

Thanks. And which is the best yaml config of the two above?

This one:

analytics:
  enabled: true
  services:
    # Google Analytics
    google:
      id: G-H4LBG7NDFZ
      respectDoNotTrack: false

You don't need to make many changes to this, this section is already in the current hugo.yaml file. You just need to change the id.

[jamesdeluk]

This one:

analytics:
  enabled: true
  services:
    # Google Analytics
    google:
      id: G-H4LBG7NDFZ
      respectDoNotTrack: false

You don't need to make many changes to this, this section is already in the current hugo.yaml file. You just need to change the id.

Great, thanks! And I guess respectDoNotTrack can be set to true and it'll still work?

[joyao]

Great, thanks! And I guess respectDoNotTrack can be set to true and it'll still work?

Yes, it should work. :)

[joyao]

Hi @hossainemruz, I believe it works as expected. Please take your time reviewing it. Thank you.

[hossainemruz]

Sorry for taking this long. I had plan to merge it this weekend but couldn't make it. I will definitely make sure to merge within next weekend.