sidestep Jest failing when converting to ESM #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over [here](jestjs/jest#9771) there's a bit of a kafuffle around the way that Jest is resolving modules. When trying to import `ipfs-core` using ESM inside Jest tests, it breaks because Jest seems to get confused when `module.exports` and `require` are part of the same expression. Breaking it up as proposed makes the problem go away.
|
Thank you @inverted-capital ; works great for me! I'm using a resolution to your patch while waiting for the pull request to be accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over here there's a bit of a kafuffle around the way that Jest is resolving modules.
When trying to import
ipfs-coreusing ESM inside Jest tests, it breaks because Jest seems to get confused whenmodule.exportsandrequireare part of the same expression. Breaking it up as proposed makes the problem go away.