Replace deprecated aliases HomeAssistantType and ServiceCallType #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hultenvp#369 HomeAssistantType was used from solis, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'solis' custom integration ServiceCallType was used from solis, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.ServiceCall instead, please report it to the author of the 'solis' custom integration
hannes3510
approved these changes
Jun 27, 2024
| @@ -8,10 +8,10 @@ | |||
| import voluptuous as vol | |||
| from homeassistant.config_entries import ConfigEntry, SOURCE_IMPORT | |||
| from homeassistant.const import Platform, ATTR_NAME, CONF_NAME | |||
| from homeassistant.core import HomeAssistant | |||
| from homeassistant.core import HomeAssistant, ServiceCall | |||
There was a problem hiding this comment.
FYI, ServiceCall is not used in this file so you can remove this too.
Suggested change
| from homeassistant.core import HomeAssistant, ServiceCall | |
| from homeassistant.core import HomeAssistant |
|
Thanks for this @rneubert. I literally came here to submit my own PR for this and found yours. :) |
CraigCallender
approved these changes
Jul 4, 2024
hannes3510
approved these changes
Jul 9, 2024
|
Thanks -- this is now merged into #380 as a combined PR. |
|
As this one is merged via #380 I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369
HomeAssistantType was used from solis, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.HomeAssistant instead, please report it to the author of the 'solis' custom integration
ServiceCallType was used from solis, this is a deprecated alias which will be removed in HA Core 2025.5. Use homeassistant.core.ServiceCall instead, please report it to the author of the 'solis' custom integration