feat: azure support #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-stephenson
force-pushed
the
azure-support
branch
from
d4fc9a0 to
3df3b74
Compare
| echo "${{ secrets.ACR_PUSH_SP_PASSWORD }}" | docker login \ | ||
| ${{ secrets.ACR_SERVER_NAME }} \ | ||
| -u ${{ secrets.ACR_PUSH_SP_ID }} \ | ||
| --password-stdin |
There was a problem hiding this comment.
We generally try to use workload identity and avoid hardcoding passwords, it seems this is also supported on azure https://github.com/Azure/login?tab=readme-ov-file#login-with-openid-connect-oidc-recommended
There was a problem hiding this comment.
Okay. Then I would close this PR. Just enabling this for people to use Backstage with Azure.
There was a problem hiding this comment.
Moving to draft for now.
There was a problem hiding this comment.
Yup, I think we should start with this one, in order to have this officially supporting Azure, and then later figure out the passwordless way to do that.
Merged
|
Replaced by #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling of Azure Container Registry