feat: backstage v1.29.2 #36

louisbennett · 2024-08-13T08:45:49Z

I.e.: yarn backstage-cli versions:bump --release 1.29.2

louisbennett · 2024-08-13T08:53:58Z

FYI @damien-duignan @aziz-haddad unrelated to this PR, this package has some errors in React relating to what appear to be Humanitec UI components:

 PASS   @humanitec/backstage-plugin  plugins/humanitec/src/plugin.test.ts
 PASS   @humanitec/backstage-plugin-common  plugins/humanitec-common/src/clients/fetch-app-info.test.ts
 PASS   @humanitec/backstage-plugin-backend  plugins/humanitec-backend/src/service/app-info-service.test.ts
 PASS   @humanitec/backstage-plugin  plugins/humanitec/src/components/HumanitecCardComponent.test.tsx
  ● Console

    console.error
      Warning: Each child in a list should have a unique "key" prop.
      
      Check the render method of `HumanitecCardContent`. See https://reactjs.org/link/warning-keys for more information.
          at env (/Users/louis/code/humanitec-backstage-plugins/plugins/humanitec/src/components/EnvironmentCard.tsx:14:3)
          at environments (/Users/louis/code/humanitec-backstage-plugins/plugins/humanitec/src/components/HumanitecCardContent.tsx:21:3)
          at div
          at CardContent (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/CardContent/CardContent.js:35:23)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at div
          at Paper (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Paper/Paper.js:55:23)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at Card (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Card/Card.js:34:23)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at HumanitecCardComponent (/Users/louis/code/humanitec-backstage-plugins/plugins/humanitec/src/components/HumanitecCardComponent.tsx:22:40)
          at attributes (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-plugin-api/src/analytics/AnalyticsContext.tsx:70:11)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/plugin-catalog-react/src/hooks/useEntity.tsx:59:11)
          at entity (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/plugin-catalog-react/src/hooks/useEntity.tsx:93:19)
          at apis (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/apis/system/ApiProvider.tsx:44:11)
          at apis (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/test-utils/src/testUtils/TestApiProvider.tsx:132:43)
          at basenameProp (/Users/louis/code/humanitec-backstage-plugins/node_modules/react-router/lib/components.tsx:413:13)
          at basename (/Users/louis/code/humanitec-backstage-plugins/node_modules/react-router/lib/components.tsx:219:3)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/test-utils/src/testUtils/appWrappers.tsx:143:18)
          at AppRouter (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppRouter.tsx:107:5)
          at Suspense
          at routePaths (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/routing/RoutingProvider.tsx:44:3)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/ThemeProvider/ThemeProvider.js:48:24)
          at StylesProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/StylesProvider/StylesProvider.js:57:24)
          at RtlProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/system/RtlProvider/index.js:19:7)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/private-theming/node/ThemeProvider/ThemeProvider.js:39:5)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/system/ThemeProvider/ThemeProvider.js:51:5)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/material/node/styles/ThemeProvider.js:21:14)
          at StyledEngineProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/styled-engine/node/StyledEngineProvider/StyledEngineProvider.js:27:5)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/theme/src/unified/UnifiedThemeProvider.tsx:69:11)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/test-utils/src/testUtils/appWrappers.tsx:155:22)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppThemeProvider.tsx:70:36)
          at appContext (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppContext.tsx:31:3)
          at apis (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/apis/system/ApiProvider.tsx:44:11)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppManager.tsx:241:25)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/test-utils/src/testUtils/appWrappers.tsx:194:29)

      43 |         Environments
      44 |       </Typography>
    > 45 |       <CardContainer>
         |       ^
      46 |         {environments.length ? (
      47 |           environments.map(e => (
      48 |             <EnvironmentCard

      at printWarning (../../../node_modules/react/cjs/react-jsx-runtime.development.js:87:30)
      at error (../../../node_modules/react/cjs/react-jsx-runtime.development.js:61:7)
      at validateExplicitKey (../../../node_modules/react/cjs/react-jsx-runtime.development.js:1078:5)
      at validateChildKeys (../../../node_modules/react/cjs/react-jsx-runtime.development.js:1105:11)
      at jsxWithValidation (../../../node_modules/react/cjs/react-jsx-runtime.development.js:1277:11)
      at jsxWithValidationDynamic (../../../node_modules/react/cjs/react-jsx-runtime.development.js:1320:12)
      at HumanitecCardContent (components/HumanitecCardContent.tsx:45:7)
      at renderWithHooks (../../../node_modules/react-dom/cjs/react-dom.development.js:15486:18)
      at mountIndeterminateComponent (../../../node_modules/react-dom/cjs/react-dom.development.js:20103:13)
      at beginWork (../../../node_modules/react-dom/cjs/react-dom.development.js:21626:16)
      at beginWork$1 (../../../node_modules/react-dom/cjs/react-dom.development.js:27465:14)
      at performUnitOfWork (../../../node_modules/react-dom/cjs/react-dom.development.js:26599:12)
      at workLoopSync (../../../node_modules/react-dom/cjs/react-dom.development.js:26505:5)
      at renderRootSync (../../../node_modules/react-dom/cjs/react-dom.development.js:26473:7)
      at performConcurrentWorkOnRoot (../../../node_modules/react-dom/cjs/react-dom.development.js:25777:74)
      at flushActQueue (../../../node_modules/react/cjs/react.development.js:2667:24)
      at recursivelyFlushAsyncActWork (../../../node_modules/react/cjs/react.development.js:2633:9)
      at ../../../node_modules/react/cjs/react.development.js:2545:15

    console.error
      Warning: findDOMNode is deprecated and will be removed in the next major release. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
          at a
          at ButtonBase (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/ButtonBase/ButtonBase.js:94:22)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at Button (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Button/Button.js:313:24)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at div
          at div
          at CardHeader (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/CardHeader/CardHeader.js:61:22)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at div
          at Paper (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Paper/Paper.js:55:23)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at Card (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Card/Card.js:34:23)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at HumanitecCardComponent (/Users/louis/code/humanitec-backstage-plugins/plugins/humanitec/src/components/HumanitecCardComponent.tsx:22:40)
          at attributes (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-plugin-api/src/analytics/AnalyticsContext.tsx:70:11)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/plugin-catalog-react/src/hooks/useEntity.tsx:59:11)
          at entity (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/plugin-catalog-react/src/hooks/useEntity.tsx:93:19)
          at apis (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/apis/system/ApiProvider.tsx:44:11)
          at apis (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/test-utils/src/testUtils/TestApiProvider.tsx:132:43)
          at basenameProp (/Users/louis/code/humanitec-backstage-plugins/node_modules/react-router/lib/components.tsx:413:13)
          at basename (/Users/louis/code/humanitec-backstage-plugins/node_modules/react-router/lib/components.tsx:219:3)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/test-utils/src/testUtils/appWrappers.tsx:143:18)
          at AppRouter (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppRouter.tsx:107:5)
          at Suspense
          at routePaths (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/routing/RoutingProvider.tsx:44:3)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/ThemeProvider/ThemeProvider.js:48:24)
          at StylesProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/StylesProvider/StylesProvider.js:57:24)
          at RtlProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/system/RtlProvider/index.js:19:7)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/private-theming/node/ThemeProvider/ThemeProvider.js:39:5)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/system/ThemeProvider/ThemeProvider.js:51:5)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/material/node/styles/ThemeProvider.js:21:14)
          at StyledEngineProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/styled-engine/node/StyledEngineProvider/StyledEngineProvider.js:27:5)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/theme/src/unified/UnifiedThemeProvider.tsx:69:11)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/test-utils/src/testUtils/appWrappers.tsx:155:22)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppThemeProvider.tsx:70:36)
          at appContext (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppContext.tsx:31:3)
          at apis (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/apis/system/ApiProvider.tsx:44:11)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppManager.tsx:241:25)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/test-utils/src/testUtils/appWrappers.tsx:194:29)

      at printWarning (../../../node_modules/react-dom/cjs/react-dom.development.js:86:30)
      at error (../../../node_modules/react-dom/cjs/react-dom.development.js:60:7)
      at Object.findDOMNode (../../../node_modules/react-dom/cjs/react-dom.development.js:29666:7)
      at ../../../node_modules/@material-ui/core/utils/useIsFocusVisible.js:151:25
      at setRef (../../../node_modules/@material-ui/core/utils/setRef.js:11:5)
      at ../../../node_modules/@material-ui/core/utils/useForkRef.js:28:27
      at setRef (../../../node_modules/@material-ui/core/utils/setRef.js:11:5)
      at ../../../node_modules/@material-ui/core/utils/useForkRef.js:29:27
      at commitAttachRef (../../../node_modules/react-dom/cjs/react-dom.development.js:23689:18)
      at commitLayoutEffectOnFiber (../../../node_modules/react-dom/cjs/react-dom.development.js:23542:9)
      at commitLayoutMountEffects_complete (../../../node_modules/react-dom/cjs/react-dom.development.js:24727:9)
      at commitLayoutEffects_begin (../../../node_modules/react-dom/cjs/react-dom.development.js:24713:7)
      at commitLayoutEffects_begin (../../../node_modules/react-dom/cjs/react-dom.development.js:24695:11)
      at commitLayoutEffects (../../../node_modules/react-dom/cjs/react-dom.development.js:24651:3)
      at commitRootImpl (../../../node_modules/react-dom/cjs/react-dom.development.js:26862:5)
      at commitRoot (../../../node_modules/react-dom/cjs/react-dom.development.js:26721:5)
      at finishConcurrentRender (../../../node_modules/react-dom/cjs/react-dom.development.js:26020:9)
      at performConcurrentWorkOnRoot (../../../node_modules/react-dom/cjs/react-dom.development.js:25848:7)
      at flushActQueue (../../../node_modules/react/cjs/react.development.js:2667:24)
      at recursivelyFlushAsyncActWork (../../../node_modules/react/cjs/react.development.js:2633:9)
      at ../../../node_modules/react/cjs/react.development.js:2545:15

 PASS   app  packages/app/src/App.test.tsx
  ● Console

    console.error
      Warning: findDOMNode is deprecated and will be removed in the next major release. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
          at button
          at ButtonBase (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/ButtonBase/ButtonBase.js:94:22)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at Button (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Button/Button.js:313:24)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at div
          at CardActions (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/CardActions/CardActions.js:41:37)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at ErrorBoundary2 (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-components/src/layout/ErrorBoundary/ErrorBoundary.tsx:73:5)
          at div
          at Paper (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Paper/Paper.js:55:23)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at Card (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Card/Card.js:34:23)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at title (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-components/src/layout/InfoCard/InfoCard.tsx:169:5)
          at li
          at Grid (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Grid/Grid.js:243:35)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-components/src/layout/SignInPage/styles.tsx:40:28)
          at onSignInStarted (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-components/src/layout/SignInPage/guestProvider.tsx:47:3)
          at ul
          at Grid (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/core/Grid/Grid.js:243:35)
          at WithStyles (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at article
          at className (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-components/src/layout/Content/Content.tsx:64:11)
          at main
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/ThemeProvider/ThemeProvider.js:48:24)
          at themeId (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-components/src/layout/Page/Page.tsx:51:11)
          at onSignInSuccess (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-components/src/layout/SignInPage/SignInPage.tsx:55:3)
          at SignInPage (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-components/src/layout/SignInPage/SignInPage.tsx:201:7)
          at SignInPage
          at Component (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppRouter.tsx:64:14)
          at basenameProp (/Users/louis/code/humanitec-backstage-plugins/node_modules/react-router/lib/components.tsx:413:13)
          at basename (/Users/louis/code/humanitec-backstage-plugins/node_modules/react-router-dom/index.tsx:774:3)
          at AppRouter (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppRouter.tsx:107:5)
          at Suspense
          at routePaths (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/routing/RoutingProvider.tsx:44:3)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/ThemeProvider/ThemeProvider.js:48:24)
          at StylesProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@material-ui/styles/StylesProvider/StylesProvider.js:57:24)
          at RtlProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/system/RtlProvider/index.js:19:7)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/private-theming/node/ThemeProvider/ThemeProvider.js:39:5)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/system/ThemeProvider/ThemeProvider.js:51:5)
          at ThemeProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/material/node/styles/ThemeProvider.js:21:14)
          at StyledEngineProvider (/Users/louis/code/humanitec-backstage-plugins/node_modules/@mui/styled-engine/node/StyledEngineProvider/StyledEngineProvider.js:27:5)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/theme/src/unified/UnifiedThemeProvider.tsx:69:11)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/app-defaults/src/defaults/themes.tsx:32:18)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppThemeProvider.tsx:70:36)
          at appContext (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppContext.tsx:31:3)
          at apis (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/apis/system/ApiProvider.tsx:44:11)
          at children (/Users/louis/code/humanitec-backstage-plugins/node_modules/@backstage/core-app-api/src/app/AppManager.tsx:241:25)
          at AppRoot

      at printWarning (../../../node_modules/react-dom/cjs/react-dom.development.js:86:30)
      at error (../../../node_modules/react-dom/cjs/react-dom.development.js:60:7)
      at Object.findDOMNode (../../../node_modules/react-dom/cjs/react-dom.development.js:29666:7)
      at ../../../node_modules/@material-ui/core/utils/useIsFocusVisible.js:151:25
      at setRef (../../../node_modules/@material-ui/core/utils/setRef.js:11:5)
      at ../../../node_modules/@material-ui/core/utils/useForkRef.js:28:27
      at setRef (../../../node_modules/@material-ui/core/utils/setRef.js:11:5)
      at ../../../node_modules/@material-ui/core/utils/useForkRef.js:29:27
      at commitAttachRef (../../../node_modules/react-dom/cjs/react-dom.development.js:23689:18)
      at commitLayoutEffectOnFiber (../../../node_modules/react-dom/cjs/react-dom.development.js:23542:9)
      at commitLayoutMountEffects_complete (../../../node_modules/react-dom/cjs/react-dom.development.js:24727:9)
      at commitLayoutEffects_begin (../../../node_modules/react-dom/cjs/react-dom.development.js:24713:7)
      at commitLayoutEffects_begin (../../../node_modules/react-dom/cjs/react-dom.development.js:24695:11)
      at commitLayoutEffects (../../../node_modules/react-dom/cjs/react-dom.development.js:24651:3)
      at commitRootImpl (../../../node_modules/react-dom/cjs/react-dom.development.js:26862:5)
      at commitRoot (../../../node_modules/react-dom/cjs/react-dom.development.js:26721:5)
      at performSyncWorkOnRoot (../../../node_modules/react-dom/cjs/react-dom.development.js:26156:3)
      at flushSyncCallbacks (../../../node_modules/react-dom/cjs/react-dom.development.js:12042:22)
      at commitRootImpl (../../../node_modules/react-dom/cjs/react-dom.development.js:26998:3)
      at commitRoot (../../../node_modules/react-dom/cjs/react-dom.development.js:26721:5)
      at finishConcurrentRender (../../../node_modules/react-dom/cjs/react-dom.development.js:26020:9)
      at performConcurrentWorkOnRoot (../../../node_modules/react-dom/cjs/react-dom.development.js:25848:7)
      at workLoop (../../../node_modules/scheduler/cjs/scheduler.development.js:266:34)
      at flushWork (../../../node_modules/scheduler/cjs/scheduler.development.js:239:14)
      at performWorkUntilDeadline (../../../node_modules/scheduler/cjs/scheduler.development.js:533:21)
      at Timeout.task [as _onTimeout] (../../../node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)


Test Suites: 5 passed, 5 total
Tests:       14 passed, 14 total
Snapshots:   0 total
Time:        3.513 s
Ran all test suites in 4 projects.

astromechza

Seems legit, all dep changes look reasonable. Although proof is in the pudding of actually testing for any behavior regressions.

louisbennett requested a review from astromechza August 13, 2024 08:45

louisbennett marked this pull request as draft August 13, 2024 08:47

louisbennett force-pushed the 1.29 branch from b2f1e1a to 3ac342a Compare August 13, 2024 08:50

louisbennett marked this pull request as ready for review August 13, 2024 08:52

astromechza approved these changes Aug 13, 2024

View reviewed changes

louisbennett added 3 commits August 21, 2024 15:48

feat: backstage v1.29.2

2f5986a

Bump @janis-idp/cli to support backstage version

0bd79f8

Bump @janus-idp/cli again

f41df15

louisbennett force-pushed the 1.29 branch from 2b93907 to f41df15 Compare August 21, 2024 14:38

louisbennett merged commit 6666cb8 into main Aug 21, 2024
1 check passed

louisbennett deleted the 1.29 branch August 21, 2024 14:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: backstage v1.29.2 #36

feat: backstage v1.29.2 #36

louisbennett commented Aug 13, 2024 •

edited

Loading

louisbennett commented Aug 13, 2024

astromechza left a comment

feat: backstage v1.29.2 #36

feat: backstage v1.29.2 #36

Conversation

louisbennett commented Aug 13, 2024 • edited Loading

louisbennett commented Aug 13, 2024

astromechza left a comment

Choose a reason for hiding this comment

louisbennett commented Aug 13, 2024 •

edited

Loading