feat: new dependency graph #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjenek
force-pushed
the
new_dependency_graph
branch
6 times, most recently
from
52b40ad to
b8a78a4
Compare
mateuszjenek
force-pushed
the
new_dependency_graph
branch
3 times, most recently
from
002954b to
4f5faec
Compare
|
@mateuszjenek, anything missing here to merge this and publish a new version? That's awesome! |
damien-duignan
requested changes
Dec 12, 2024
| } else if (result.stderr.includes('environment is required')) { | ||
| } else if ( | ||
| result.stderr.includes('environment is required') || | ||
| result.stderr.includes('missing env') |
There was a problem hiding this comment.
Where are these new errors coming from?
There was a problem hiding this comment.
CLI returns unconsistent error messages and I found out that in most places it returns: environment is required, but in some: missing env
src/repos/DeploymentRepository.ts
Outdated
Comment on lines
22
to
30
| const deploymentUrl = | ||
| '/orgs/' + | ||
| organizationId + | ||
| '/apps/' + | ||
| applicationId + | ||
| '/envs/' + | ||
| environmentId + | ||
| '/deploys/' + | ||
| deployId; |
There was a problem hiding this comment.
Suggested change
| const deploymentUrl = | |
| '/orgs/' + | |
| organizationId + | |
| '/apps/' + | |
| applicationId + | |
| '/envs/' + | |
| environmentId + | |
| '/deploys/' + | |
| deployId; | |
| const deploymentUrl = `/orgs/${organizationId}/apps/${applicationId}/envs/${environmentId}/deploys/${deployId}`; |
There was a problem hiding this comment.
Nice suggestion, applied in all places!
mateuszjenek
force-pushed
the
new_dependency_graph
branch
from
4f5faec to
ec3a27e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace old graph library with the new Humanitec Resource Graph component
Result:
