Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested fields flattened into an object and test cases #126

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

ferh6t
Copy link
Contributor

@ferh6t ferh6t commented Nov 14, 2024

Related Issue(s)
Related to issue #114

Added small function for nested objects for json logs. Test cases also includes an example for nested object.

@aybabtme
Copy link
Collaborator

thanks @ferh6t ☺️ do you mind fixing the failing tests?

@aybabtme
Copy link
Collaborator

@ferh6t I think this will work, but you'll need to rebase against the master branch to pick up the change to golangci-lint, similar to #127 (comment).

@aybabtme
Copy link
Collaborator

actually rerunning it made it pass. when merged to master, i'll run with the --fast flag so this is good to merge. thanks @ferh6t !

@aybabtme aybabtme merged commit 987e8d9 into humanlogio:master Nov 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants