This repository has been archived by the owner on Oct 13, 2020. It is now read-only.
Fixes: #126, #119, #25, #72 #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- WPThumb & Media Manager #72 - By default we should stop WordPress generating any of the image sizes on upload #25 ## Pull Request details: WPThumb stores resized images in the cache folder, making it easy to backup only the originals. Problem is that it doesn't work for the core intermediate sizes so it mixes those resized images with the originals. Bad for backups. A workaround was to disable the intermediate sizes in the media settings (by setting the size values to '0') to prevent Wordpress from cluttering up the uploads folder with unused theme sizes. This is bad practice as the intermediate sizes are used throughout the WP-Admin and in the Media gallery. Without them, the original image sizes are always loaded and simply scaled down to fit by the browser. This fix uses WPThumb to generate the core intermediate image sizes (thumbnail, medium, large) on upload, instead of Wordpress.
|
Hi @joehoyle, please look over this PR. Thanks |
|
Ping @joehoyle |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split up the pull request into 3 separate commits.
If accepted, would you tag and make sure it gets pushed up to the WordPress Subversion repository? (For composer managed projects - http://wpackagist.org)