-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix attribute post type handling #113
base: develop
Are you sure you want to change the base?
Conversation
Noting this needs the phpstan fix merging in from #112 for CI to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a test to be added to demonstrate what the current problem is.
@johnbillion I tracked the issue down further:
As a result, if a user does not have I've had some success with this filter:
With that I'm able to change the authors attributed when logged in as an author with the This also fixes things without the changes in this PR though, so this PR should be considered at best a readability/inline documentation improvement.
I do not know how to write this test |
WIP fix for #111