Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP version testing #135

Merged
merged 12 commits into from
Jul 25, 2024
Merged

PHP version testing #135

merged 12 commits into from
Jul 25, 2024

Conversation

johnbillion
Copy link
Member

@johnbillion johnbillion commented Aug 29, 2023 •
edited
Loading

We're quite behind with PHP version testing. This adds testing up to PHP 8.3.

Once this is in place we can look at bumping the phpcs packages, the minimum supported PHP version, and the node version used for the build.

roborourke
roborourke approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All passing, plus bumped to WP 6.6 for good measure

@roborourke roborourke merged commit c548d2e into develop Jul 25, 2024
7 checks passed
@roborourke roborourke deleted the php-testing branch July 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborourke roborourke roborourke approved these changes

@kadamwhite kadamwhite Awaiting requested review from kadamwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnbillion @roborourke