Fixing builds and start command #149
Conversation
README.md
Outdated
| Tested up to: 6.2 | ||
| Requires PHP: 7.2 | ||
| License: GPL v3 or later | ||
| Contributors: johnbillion, humanmade |
There was a problem hiding this comment.
These trailing spaces need to be retained, they're line breaks
There was a problem hiding this comment.
I think that'll be my editor set to remove them automatically, but that's weird no? Why would spaces at the end of a line be line breaks?
There was a problem hiding this comment.
| @@ -61,9 +61,10 @@ _Features without a checkmark are still work in progress._ | |||
| ### For development use | |||
|
|
|||
| * Clone this repo into your plugins directory | |||
| * Install the dependencies: | |||
| * Ensure you have Composer v2 and Node v16 installed | |||
There was a problem hiding this comment.
Would it make more sense to explicitly mention nvm use?
There was a problem hiding this comment.
@tomjn I'm going to update it all soon anyway, the specific tool people use to manage node versions is up to them
There was a problem hiding this comment.
All looks good. This reminds me that #25 would be great to get done too.
|
@johnbillion for #25 I think the e2e stuff provided by wp-scripts is the way to go. |
Temporary resolution for #115 and #114