fix: container issue from api change and ci update

humbertogontijo · Dec 18, 2024 · 1bfb09f · 1bfb09f
1 parent de0a0c7
commit 1bfb09f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -79,7 +79,7 @@ jobs:
       id: release
       uses: python-semantic-release/[email protected]
       with:
-        github_token: ${{ secrets.DEPLOY_KEY }}
+        github_token: ${{ secrets.GH_TOKEN }}
 
     - name: Publish package distributions to PyPI
       uses: pypa/[email protected]
@@ -92,4 +92,4 @@ jobs:
       uses: python-semantic-release/[email protected]
       if: steps.release.outputs.released == 'true'
       with:
-        github_token: ${{ secrets.DEPLOY_KEY }}
+        github_token: ${{ secrets.GH_TOKEN }}
diff --git a/roborock/containers.py b/roborock/containers.py
@@ -141,12 +141,12 @@ def from_dict(cls, data: dict[str, Any]):
                 cls_annotations.update(getattr(base, "__annotations__", {}))
             remove_keys = []
             for key, value in data.items():
-                if value == "None" or value is None:
-                    data[key] = None
-                    continue
                 if key not in cls_annotations:
                     remove_keys.append(key)
                     continue
+                if value == "None" or value is None:
+                    data[key] = None
+                    continue
                 field_type: str = cls_annotations[key]
                 if "|" in field_type:
                     # It's a union