-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add q revo/p10 support #114
Conversation
Jezza34000
commented
Sep 4, 2023
•
edited
Loading
edited
- Adding class for FanSpeed
- Adding class for MopMode (only 2 for Q REVO)
- Adding const
- Adding many status from Q REVO get_status (some are unknow) :
-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me. Optional should cover our bases
Fix ci though please. Lint is more important than commit lint - I can fix that when merging |
Also does this really make any changes regarding q revo? Edit: I see q revo =p10? |
Yes roborock.vacuum.a75 is Q REVO or P10 |
OK i change my PR. mop_mode/route is exaclty same as S8ProUltra. |
Maybe we need a more generical name for class |
Made the changes myself so I could merge in. |
Hello thank you. 👍 |