Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datetime parsing in cleanrecord #119

Merged
merged 9 commits into from
Sep 12, 2023

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Sep 9, 2023

No description provided.

humbertogontijo
humbertogontijo previously approved these changes Sep 9, 2023
Copy link
Owner

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lash-L
Copy link
Collaborator Author

Lash-L commented Sep 9, 2023

It auto dismissed the review because I fixed linting, do you mind re-approving? @humbertogontijo

@Lash-L
Copy link
Collaborator Author

Lash-L commented Sep 9, 2023

Added one more change with a is_available bool.

@Lash-L
Copy link
Collaborator Author

Lash-L commented Sep 11, 2023

Also exposed queue timeout so it can be manipulated. Some users were facing issues with timeouts and I figured this way I can increase/decrease the timeout as needed

@Lash-L
Copy link
Collaborator Author

Lash-L commented Sep 12, 2023

@humbertogontijo When you get a chance can you approve this? I have 3/4 PRs that are going to require this merge

Copy link
Owner

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Lash-L
Copy link
Collaborator Author

Lash-L commented Sep 12, 2023

Preesh thank you

@Lash-L Lash-L merged commit 5e67fa6 into humbertogontijo:main Sep 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants