Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add S5Max Mop Code 207 #132

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix: Add S5Max Mop Code 207 #132

merged 1 commit into from
Oct 28, 2023

Conversation

shbatm
Copy link
Contributor

@shbatm shbatm commented Oct 27, 2023

Add Mop Code 207 to eliminate error:

Logger: roborock.code_mappings
Source: runner.py:186
First occurred: 5:41:40 PM (1 occurrences)
Last logged: 5:41:40 PM

Missing RoborockMopIntensityS5Max code: 207 - defaulting to 200

@Lash-L Lash-L changed the title Add S5Max Mop Code 207 fix: Add S5Max Mop Code 207 Oct 28, 2023
@Lash-L
Copy link
Collaborator

Lash-L commented Oct 28, 2023

Just to confirm @shbatm you have a s5 max, right? We were previously using the s5 max intensity for a few other modes and on older version of the package that could be confusing, so I just want to double check bckfore I merge. But otherwise LGTM - you can ignore commit lint.

@shbatm
Copy link
Contributor Author

shbatm commented Oct 28, 2023

Correct, this is from my S5 Max.

@Lash-L Lash-L merged commit adc7ae0 into humbertogontijo:main Oct 28, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lash-L Lash-L Lash-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shbatm @Lash-L