Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typing and versioning #134

Merged
merged 4 commits into from
Oct 29, 2023
Merged

fix: typing and versioning #134

merged 4 commits into from
Oct 29, 2023

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Oct 29, 2023

I think adding poetry lock may help with our dacite issues from a bit of what I am reading

I also made a few changes for variables that we know we will have/ we rely on having to make them not None

humbertogontijo
humbertogontijo approved these changes Oct 29, 2023
View reviewed changes
Copy link
Owner

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give it a try

@Lash-L Lash-L merged commit e1dc545 into humbertogontijo:main Oct 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humbertogontijo humbertogontijo humbertogontijo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lash-L @humbertogontijo