Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions review - necessary updates and features #45

Merged
merged 12 commits into from
Nov 18, 2019
Merged

Conversation

matuskosut
Copy link
Collaborator

Long time without updates. Let's begin with keeping up with libjuju (and other dependencies).

To support authentication from remote machine we have to add --cacert $CACERT.

We will be changing version to 0.2.0 - making some features more general

Changed

  • Dependency versions updated to current libjuju (waiting only for macaroonbakery to also support python 3.8)
  • Allow upgrade without using origin - if not supported by charm - origin now has to be specified explicitly
  • Charm upgrade does not check locally built ('local:app') charms
  • When using upgrade-only, charms are not compared with charmstore versions, skipping straight to upgrade of services
  • Improved wait on charm config change when setting origin
  • Minor refactor/cleanup around

Added

  • Support passing of --cacert $CACERT parameter in authentication using libjuju when accessing from remote machine
  • Origin keys can be specified as parameter (key=value,key2=value2)
  • Upgrade action name as parameters - defaulting to 'openstack-upgrade' in perform_upgrade
  • Support key value parameters for upgrade action (key=value,key2=value2)
  • Debug parameter - default log level without debug is INFO
  • Async (class) methods mocking for unit-testing of jujuna code
  • Tests for upgrade - perform_upgrade (covering simple, rolling and hacluster cases)

@matuskosut
Copy link
Collaborator Author

#14 included

2019-11-18 13:35:52,184 - jujuna.upgrade - INFO - Application upgrade order: keystone (10.0.3)
2019-11-18 13:35:52,272 - jujuna.upgrade - INFO - KEYSTONE - Begin rolling upgrade
...
2019-11-18 13:42:06,205 - jujuna.upgrade - INFO - KEYSTONE - Finish rolling upgrade
2019-11-18 13:42:08,228 - jujuna.upgrade - INFO - Application upgrade order: keystone (10.0.3=>11.0.4)

@matuskosut
Copy link
Collaborator Author

#34
We have the order documented in that script, also in the upgrade config.
It is also logged as in the messages above including versions.

@matuskosut matuskosut merged commit 51390b9 into master Nov 18, 2019
@matuskosut matuskosut deleted the versions-review branch November 18, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant