Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #1

Open
wants to merge 115 commits into
base: main
Choose a base branch
from
Open

Merge upstream #1

wants to merge 115 commits into from

Conversation

huxiuhan
Copy link
Owner

No description provided.

@johndpope
Copy link

johndpope commented Jan 24, 2024

is there a json / png workflow for this ?
here is a comfyui implementation - and has fleshed out logic. has many a bit of bloat - 3 external libraries to get working but it's there.
https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID

@huxiuhan
Copy link
Owner Author

huxiuhan commented Jan 24, 2024

is there a json / png workflow for this ? here is a comfyui implementation - and has fleshed out logic. has many a bit of bloat - 3 external libraries to get working but it's there. https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID

My implementation only involves one node, and it's very easy to use. I'll add a template workflow. I explained why I don't break up nodes in comfy way in updated README

A little more explanation: Yes, I know it's great to break down nodes; but it's diffuser based implementation and its inputs / outputs are not compatible with existing other nodes. Even if you break down nodes, those nodes are just connecting each others within the group. Let's wait for better IPAdapterPlus implementation instead of introducing yet another bunch of fancy nodes just for one purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.