Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: playback flyout ui #203

Closed
wants to merge 6 commits into from

Conversation

United600
Copy link
Collaborator

Combines and redesigns the various flyouts that can customize media playback settings.

Mock-up

Mock-up of video playback options in light and dark mode.

V1 Tasks

  • Localize strings
  • Aspect ratio ComboBox
  • Disable sliders that don't apply to audio playback
  • Override the minimum playback speed
  • Add and Bind Reset command

@quietrobot
Copy link

I would add the option to manually edit the value.

fix

@United600
Copy link
Collaborator Author

United600 commented Oct 30, 2023

I would add the option to manually edit the value.

This was how I first envisioned, for the first version we can go without it.
PlaybackOptionsVideo Dark

But I think the plan is to end up with something like this, (wip) spacing needs working.
PlaybackOptionsVideo Dark2

@quietrobot
Copy link

I like both versions! maybe a design like this for the arrows.

unli

In addition to the Aspect ratio, it would also be good to have an option to "zoom" the video (like classic VLC).

@United600
Copy link
Collaborator Author

I like both versions! maybe a design like this for the arrows.

unli

Yeah sure, I used the compact mode because sharing the row with a slider left little space for the numberbox.

Without a slider we aren't so constrained for space that we can use the normal size.

@United600 United600 marked this pull request as ready for review November 12, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants