Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rework auto resize behavior #229

Merged
merged 8 commits into from
Dec 4, 2023
Merged

feat: rework auto resize behavior #229

merged 8 commits into from
Dec 4, 2023

Conversation

huynhsontung
Copy link
Owner

@huynhsontung huynhsontung commented Nov 14, 2023 •
edited
Loading

New logic:

  • Never: Never resize auto resize the window on playback
  • OnLaunch: Only resize the window on video file launched. When the app is already open, no resize or maximize the player on video playback.
  • Always: Always resize the window on video playback when possible. Always maximize the player on video playback.

@huynhsontung huynhsontung marked this pull request as ready for review November 29, 2023 08:01
@huynhsontung huynhsontung merged commit a723ee3 into main Dec 4, 2023
4 checks passed
@huynhsontung huynhsontung deleted the fix-resize branch December 4, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huynhsontung