Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15 transform geometry #16

Merged
merged 2 commits into from
Jan 12, 2021
Merged

15 transform geometry #16

merged 2 commits into from
Jan 12, 2021

Conversation

iosefa
Copy link
Collaborator

@iosefa iosefa commented Jan 12, 2021

Fixes #15 .

Changes proposed in this pull request:

  • adds model property of transformed geometry for crm_forests

@hyakumori/maintainer

@iosefa iosefa requested a review from Torgian January 12, 2021 07:18
@iosefa iosefa self-assigned this Jan 12, 2021
iosefa added 2 commits January 12, 2021 16:18
@iosefa
transform geometry to 4326 for forest geodata
a4a0f93 
Signed-off-by: Iosefa Percival <[email protected]>
@iosefa
remove unued import
e91aeb1 
Signed-off-by: Iosefa Percival <[email protected]>
@iosefa iosefa force-pushed the 15-transform-geometry branch from ebb58b8 to e91aeb1 Compare January 12, 2021 07:19
Torgian
Torgian approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@Torgian Torgian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe later we can add a function to change transformation to 4326 or another if it becomes important.

@iosefa iosefa added this to the Integrate geospatial milestone Jan 12, 2021
@iosefa iosefa merged commit 4fd4485 into next Jan 12, 2021
@iosefa iosefa deleted the 15-transform-geometry branch January 29, 2021 11:23
iosefa added a commit that referenced this pull request Mar 10, 2021
@iosefa
Merge pull request #16 from hyakumori/15-transform-geometry
e7ce51f 
15 transform geometry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torgian Torgian Torgian approved these changes

Assignees

@iosefa iosefa

Labels
None yet
Projects
None yet
Milestone
Integrate geospatial
Development

Successfully merging this pull request may close these issues.

geometry coordinates should be in EPSG:4326
2 participants
@iosefa @Torgian