-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HydePHP v2.x Development #1565
base: master
Are you sure you want to change the base?
HydePHP v2.x Development #1565
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1565 +/- ##
============================================
Coverage 100.00% 100.00%
- Complexity 1766 1891 +125
============================================
Files 182 194 +12
Lines 4758 5044 +286
============================================
+ Hits 4758 5044 +286 ☔ View full report in Codecov by Sentry. |
class GeneratesDocumentationSearchIndex | ||
{ | ||
use InteractsWithDirectories; | ||
|
||
protected Collection $index; | ||
protected string $path; | ||
|
||
/** | ||
* Generate the search index and save it to disk. | ||
* @since v2.x This method returns the JSON string instead of saving it to disk and returning the path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really the right location, but GitHub UI is being really glitchy. But anyways; the realtime compiler is not adding the JSON headers for the served search index file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build:search command also does not seem to have output anymore.
Both of these issues are only present in the v2 branch
…search-page-title [2.x] Natural language documentation search page header generation
[2.x] Move documentation search Blade view to better match route structure
HydePHP v2.x Development
Abstract
This pull request tracks the code for HydePHP v2.x.
Roadmap:
Pull Requests
DocumentationSearchPage::generate()
method #1569null
instead of'other'
#1572docs.sidebar_order
todocs.sidebar.order
#1583docs.table_of_contents
todocs.sidebar.table_of_contents
#1584NavigationElement
contract #1640Include::path()
method will no longer create the directory #1707route
helper function to throw if the route does not exist #1741unslash
function #1754BaseUrlNotSetException
class #1760--run-dev
and--run-prod
build command flags with--run-vite
flag #2013