Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydePHP v2.x Development #1565

Draft
wants to merge 3,599 commits into
base: master
Choose a base branch
from
Draft

HydePHP v2.x Development #1565

wants to merge 3,599 commits into from

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Feb 13, 2024

HydePHP v2.x Development

Abstract

This pull request tracks the code for HydePHP v2.x.

Roadmap:

Pull Requests

@caendesilva caendesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ca6b8dc) to head (a4c41cb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##              master     #1565    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity      1766      1891   +125     
============================================
  Files            182       194    +12     
  Lines           4758      5044   +286     
============================================
+ Hits            4758      5044   +286     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva added this to the v2 milestone Feb 13, 2024
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 March 31, 2024 15:41 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 12:55 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 12:57 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 12:59 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 15:13 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 15:16 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 15:31 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 15:51 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 15:51 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 15:52 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 15:53 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 16:02 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 16:21 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 8, 2024 16:36 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 9, 2024 15:31 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 10, 2024 12:24 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 10, 2024 15:03 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 13, 2024 10:29 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 13, 2024 10:37 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 13, 2024 10:49 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 13, 2024 12:27 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-1565 April 13, 2024 12:32 — with GitHub Actions Inactive
Comment on lines 19 to +26
class GeneratesDocumentationSearchIndex
{
use InteractsWithDirectories;

protected Collection $index;
protected string $path;

/**
* Generate the search index and save it to disk.
* @since v2.x This method returns the JSON string instead of saving it to disk and returning the path.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really the right location, but GitHub UI is being really glitchy. But anyways; the realtime compiler is not adding the JSON headers for the served search index file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build:search command also does not seem to have output anymore.

Both of these issues are only present in the v2 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-visual-tests Internal label to trigger Browserstack visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants