-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Bring media assets into the Hyde kernel #1917
Merged
caendesilva
merged 22 commits into
normalize-the-asset-api
from
bring-media-assets-into-the-hyde-kernel
Jul 28, 2024
Merged
[2.x] Bring media assets into the Hyde kernel #1917
caendesilva
merged 22 commits into
normalize-the-asset-api
from
bring-media-assets-into-the-hyde-kernel
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
8a622da
to
935e0f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1917 +/- ##
===========================================================
Coverage 100.00% 100.00%
- Complexity 1873 1875 +2
===========================================================
Files 192 193 +1
Lines 4944 4948 +4
===========================================================
+ Hits 4944 4948 +4 ☔ View full report in Codecov by Sentry. |
Okay, added a more robust benchmarker in f6b8382, with about 15 files, including nested ones, and a 10MB one. # Before:
Warmup: 15.8036ms
Benchmark: 10.2105987ms # avg/1000/its
# After:
Warmup: 16.9699ms
Benchmark: 0.00093500000000001ms # avg/1000/its |
935e0f9
to
775a496
Compare
We'll see if we name this mediaFiles or assets
04e94ed
to
1d12225
Compare
Better matches other file collections
5389932
to
b0f3a89
Compare
This reverts commit f3a177c385bd72805cb529f75c276472e1939021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1904
Quick benchmarking shows this now goes from
~2.5ms
perMediaFile::files()
call to~2.7ms
for the first call, and essentially zero at all subsequent calls in the request lifecycle. This is at the cost of the kernel needing to rerun discovery if media files change during the request, which should only happen in unit testing that are coupled to the filesystem.