-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Lazy loaded MediaFile metadata properties #1933
[2.x] Lazy loaded MediaFile metadata properties #1933
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1933 +/- ##
=============================================================
- Coverage 99.97% 99.93% -0.05%
- Complexity 1883 1887 +4
=============================================================
Files 193 193
Lines 4971 4978 +7
=============================================================
+ Hits 4970 4975 +5
- Misses 1 3 +2 ☔ View full report in Codecov by Sentry. |
3fb3f11
to
b61d957
Compare
if (! isset($this->length)) { | ||
$this->boot(); | ||
} | ||
$this->ensureInstanceIsBooted('length'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically we could do something like $this->getBootedProperty()
but I think this is much more readable and understandable.
…e-kernel [2.x] Lazy loaded MediaFile metadata properties
Abstract
Changes