Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.1 #51

Merged
merged 7 commits into from
Dec 8, 2024
Merged

0.5.1 #51

merged 7 commits into from
Dec 8, 2024

Conversation

b100dian
Copy link
Contributor

@b100dian b100dian commented Oct 27, 2024

Our contribution to open a _blank target was merged.
Hydrogen-web 0.5.1 was realeased with that - and we can just use those artefacts.

However I have the impression that channel joining is not working, if you click a such link. I have removed some encoding, but don't have conclusive tests...


Also: version in About page #50

Builds at: https://build.sailfishos.org/package/show/home:b100dian:sfos-hydrogen/harbour-hydrogen


Update: Back to our own hydrogen build with 0.5.1 + patches by @ichthyosaurus

@ichthyosaurus
Copy link
Collaborator

ichthyosaurus commented Dec 2, 2024

I made a bunch of bug fixes and opened PRs for them upstream but while we wait for them to be merged, it may make sense to release an intermediate version with a manually built hydrogen pwa?

My PRs are: element-hq/hydrogen-web#1200, element-hq/hydrogen-web#1199, element-hq/hydrogen-web#1198, element-hq/hydrogen-web#1197, element-hq/hydrogen-web#1195

They fix #54, #48, #41.


Fixes #50 (this PR).

@b100dian
Copy link
Contributor Author

b100dian commented Dec 2, 2024

I made a bunch of bug fixes and opened PRs for them upstream but while we wait for them to be merged, it may make sense to release an intermediate version with a manually built hydrogen pw

On it.

So you actually figured out #41 ! great!

@ichthyosaurus
Copy link
Collaborator

I just opened element-hq/hydrogen-web#1202 (fixes replying to replies) and updated element-hq/hydrogen-web#1197.

@b100dian
Copy link
Contributor Author

b100dian commented Dec 7, 2024

Hi @ichthyosaurus , I have made a build here https://repo.sailfishos.org/obs/home:/b100dian:/sfos-hydrogen/sailfish_latest_i486/noarch/ that includes most of your fixes (except the last one) from hydrogen-web (using this branch of ours https://github.com/hydrogen-sailfishos/hydrogen-web/commits/sfos-0.5.1/ - see Squashed commit of the following.. messages).

If you find things are OK I will proceed updating it with element-hq/hydrogen-web#1202 and publish it in chum

@ichthyosaurus
Copy link
Collaborator

You're missing the three latest commits in element-hq/hydrogen-web#1197 and of course element-hq/hydrogen-web#1202 but apart from that your version seems to be working fine on my phone. Thank you! :)

@b100dian b100dian merged commit 9fdadaf into master Dec 8, 2024
@b100dian b100dian changed the title 0.5.x 0.5.1 Dec 8, 2024
@b100dian
Copy link
Contributor Author

b100dian commented Dec 8, 2024

I've pushed it to chum testing for now, thanks @ichthyosaurus for your contributions again, especially upstream work!

Which reminds that I still have to review the cover names work, will try to make that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants