Enable LSP development #1011
Merged
Enable LSP development #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package.swift
Outdated
| @@ -16,6 +16,7 @@ let package = Package( | |||
| products: [ | |||
| .executable(name: "hc", targets: ["hc"]), | |||
| .executable(name: "hylo-demangle", targets: ["hylo-demangle"]), | |||
| .library(name: "hc-lib", targets: ["Driver"]) | |||
There was a problem hiding this comment.
Suggested change
| .library(name: "hc-lib", targets: ["Driver"]) | |
| .library(name: "Hylo", targets: ["Driver"]) |
Hylo seems to better fit how Swift libraries are typically named. I am on the fence as to whether it should rather be HyloCompiler, but I can easily imagine the library's API will eventually let us interact with the interpreter we'll have to ship for compile-time evaluation.
There was a problem hiding this comment.
I am open to whatever name you guys prefer. I am very new to Swift in general and don't have a lot of experience with Swift ecosystem and best practices.
There was a problem hiding this comment.
Let's go with Hylo to start. We can split into smaller specialized libraries in the future if the need emerges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourcePosition