Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty struct init alternate #1016

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Empty struct init alternate #1016

merged 2 commits into from
Sep 17, 2023

Conversation

WalterSmuts
Copy link
Contributor

Fixes: #997

Alternative approach to #1014

kyouko-taiga
kyouko-taiga approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@kyouko-taiga kyouko-taiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach much better.

@WalterSmuts WalterSmuts force-pushed the empty-struct-init-alternate branch from 711f637 to d22f334 Compare September 17, 2023 19:39
@WalterSmuts
Copy link
Contributor Author

WalterSmuts commented Sep 17, 2023 •
edited
Loading

I like this approach much better.

Agreed. There is also a couple of other situations where this approach is already in use:

Would be inconsistent not to use the same approach for all these cases.

@kyouko-taiga kyouko-taiga merged commit 35cf03d into hylo-lang:main Sep 17, 2023
7 checks passed
@WalterSmuts WalterSmuts mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyouko-taiga kyouko-taiga kyouko-taiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structures without elements produce error in init function
2 participants
@WalterSmuts @kyouko-taiga