Fix monomorphization of constant strings in generic functions #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the monomorphization of constant strings occurring in generic functions.
In the current implementation, constant strings are lowered as references to global constants. That causes monomorphization to fail because the module in which the constant is being declared isn't necessarily the same as the module in which the monomorphized function is inserted. With this patch, constant strings are lowered with a dedicated instructions,
constant_strings, that can get rewritten in each monomorphized variant.A different way to solve this could have been to expose a symbol representing the global being referenced so that it could be referenced by another module. This approach may have to be used to deal with other kind of global references used in generic code (e.g., references to witness tables).