Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bundle.module.resourceURL to point to Hylo standard library #1097

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

nickpdemarco
Copy link
Collaborator

This change removes a hard-coded path to the standard library, which pointed to the pre-build source directory; i.e. directly to //repo-root/Library/. Instead, we use Bundle.module.resourceURL to point to the post-build location of the standard library resource files.

Copy link
Collaborator

@dabrahams dabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickpdemarco nickpdemarco merged commit 7f3508c into main Oct 17, 2023
9 checks passed
@dabrahams
Copy link
Collaborator

I don't know why I approved this. It totally broke something I had already fixed.

@kyouko-taiga kyouko-taiga deleted the npd/resource-path branch May 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants