Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose lookup functions through TypedProgram #1491

Conversation

tothambrus11
Copy link
Contributor

Two of the lookup functions from the type checker are exposed in the TypedProgram with non-mutating interface, so that they can be used from the HyloDoc library for name resolution of Hylo code references inside documentation.

The exposed functions are:

  • unqualified lookup based on a stem identifier, inside a provided scope
  • qualified lookup based on an identifier, a given type as a nominal scope and the scope of use that determines whether some conformances apply or not.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (7e2eb24) to head (5427746).
Report is 266 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1491      +/-   ##
==========================================
+ Coverage   86.96%   86.99%   +0.02%     
==========================================
  Files         366      366              
  Lines       21752    21758       +6     
==========================================
+ Hits        18917    18928      +11     
+ Misses       2835     2830       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dabrahams
Copy link
Collaborator

All newly added code should be covered by tests.

@tothambrus11 tothambrus11 force-pushed the expose-lookup-through-typed-program2 branch from 26f19c2 to 5427746 Compare June 14, 2024 11:35
@tothambrus11
Copy link
Contributor Author

Hi, I added tests, can you take a look again?

@tothambrus11 tothambrus11 reopened this Sep 19, 2024
@tothambrus11
Copy link
Contributor Author

Closing this PR, as the current form of the type checker is going to be replaced in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants