Add support for non-consuming projections of union payloads #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous design of the instruction did not require the operand to be the result of a 'let' access, which would cause problems during access reification. The new design consumes a discriminator value that must have been obtained from 'union_discriminator'. An alternative design could be to require that the first operand be an access that would be passed as a basic block arguments to the different targets. This approach makes it more difficult to track lifetime dependencies, though.
|
This PR implements #1099. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
+ Coverage 87.76% 87.83% +0.06%
==========================================
Files 373 373
Lines 22621 22627 +6
==========================================
+ Hits 19854 19875 +21
+ Misses 2767 2752 -15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following program is now legal:
Previously, the compiler would complain that
xcan't be consumed because all narrowing conversions required asinkaccess on the source.