Validate maxTokens and limit conversation history to maxRecord.

hyperf · Feb 6, 2025 · be4f2af · be4f2af
1 parent cc3fc15
commit be4f2af
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Memory/MessageHistory.php b/src/Memory/MessageHistory.php
@@ -25,7 +25,9 @@ public function __construct(
         protected int $maxTokens = 1000,
         array $conversations = []
     ) {
-        // @todo validate $maxTokens
+        if ($maxTokens <= 0) {
+            throw new InvalidArgumentException('maxTokens must be greater than zero.');
+        }
     }
 
     public function setSystemMessage(MessageInterface $message, string|Stringable $conversationId): static
@@ -52,8 +54,9 @@ public function addMessages(array|MessageInterface $messages, string|Stringable
 
         foreach ($messages as $message) {
             $this->conversations[$conversationId][] = $message;
+            // Ensure the number of messages does not exceed maxRecord
             if (count($this->conversations[$conversationId]) > $this->maxRecord) {
-                array_shift($this->conversations[$conversationId]);
+                $this->conversations[$conversationId] = array_slice($this->conversations[$conversationId], -$this->maxRecord);
             }
         }