Fix RecvStream::is_end_stream(): return true only when END_STREAM is received #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaufavor
force-pushed
the
end_stream-check
branch
from
0327d9f
to
dad7572
Compare
seanmonstar
reviewed
Nov 12, 2024
| pub fn is_recv_closed(&self) -> bool { | ||
| matches!( | ||
| self.inner, | ||
| Closed(..) | HalfClosedRemote(..) | ReservedLocal |
There was a problem hiding this comment.
I've given this some thought, and I'm less sure that we want the check to be so strict. If it is half-closed successfully, I think we do want to say that the RecvStream is finished. If there is later an error on the sending side, I don't think that should be a problem, the SendStream will notice.
There was a problem hiding this comment.
Good point. Updated to check both Closed(Cause::EndStream) and HalfClosedRemote(..). Also updated the function name accordingly.
…received Before this change, it returned true on other types of disconnection as well. Fixes hyperium#806
eaufavor
force-pushed
the
end_stream-check
branch
from
dad7572
to
1857605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, it returned true on other types of disconnection as well.
Fixes #806
Removed unused
is_recv_closed().