-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ping): #1260 deprecate ping request #1288
feat(ping): #1260 deprecate ping request #1288
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
+ Coverage 62.51% 63.77% +1.25%
==========================================
Files 112 108 -4
Lines 3391 3376 -15
Branches 591 572 -19
==========================================
+ Hits 2120 2153 +33
+ Misses 1079 1040 -39
+ Partials 192 183 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok looks good. approved on Hari's feedback updated.
Monika Pull Request (PR)
What feature/issue does this PR add
This PR is a deprecation step before removing ping from HTTP probe. See #1260
How did you implement / how did you fix it
"ping: true"
frommonika-config-schema.json
monika.yml
sampleHow to test
npm run start -- -r 1