Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ping): #1260 deprecate ping request #1288

Merged

Conversation

syamsudotdev
Copy link
Contributor

@syamsudotdev syamsudotdev commented May 9, 2024

Monika Pull Request (PR)

What feature/issue does this PR add

This PR is a deprecation step before removing ping from HTTP probe. See #1260

How did you implement / how did you fix it

  1. Remove "ping: true" from monika-config-schema.json
  2. Add deprecation warning to startup message
  3. Add deprecation warning to HTTP probe message
  4. Update ping tutorial
  5. Update monika.yml sample

How to test

  1. Setup monika configuration below
probes:
  - id: 'ping_test'
    name: ping_test
    description: requesting icmp ping
    interval: 10
    requests:
      - url: http://google.com
        ping: true
    alerts:
      - assertion: response.status != 200
        message: response status message
  1. npm run start -- -r 1
  2. Expected screenshot below
    image

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 63.77%. Comparing base (6a29470) to head (c489e90).
Report is 12 commits behind head on main.

Files Patch % Lines
src/components/logger/startup-message.ts 0.00% 3 Missing and 1 partial ⚠️
src/components/probe/prober/http/request.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
+ Coverage   62.51%   63.77%   +1.25%     
==========================================
  Files         112      108       -4     
  Lines        3391     3376      -15     
  Branches      591      572      -19     
==========================================
+ Hits         2120     2153      +33     
+ Misses       1079     1040      -39     
+ Partials      192      183       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

monika.example.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok looks good. approved on Hari's feedback updated.

@syamsudotdev syamsudotdev merged commit c9fb205 into hyperjumptech:main May 13, 2024
7 checks passed
@syamsudotdev syamsudotdev deleted the issue/1260-deprecate-ping-request branch May 13, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants