Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove axios package #1314

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

irwansyahwii
Copy link

@irwansyahwii irwansyahwii commented Jul 19, 2024

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Remove Axios and replace it with native fetch

How did you implement / how did you fix it

  1. Create an adapter httpClient to prevent big changes on the client codes

How to test

  1. npm run test

Copy link
Contributor

@suyono3484 suyono3484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irwansyahwii, could you double check the test result? I ran the test locally and it failed. You can run the test locally by running

npm run test

One of the failed test is src/components/probe/prober/http/request.test.ts. You can run the failed test specifically by using

mocha --config .mocharc.json --forbid-only src/components/probe/prober/http/request.test.ts

I think the failed tests are blocking the github checks.

@irwansyahwii
Copy link
Author

Hi @irwansyahwii, could you double check the test result? I ran the test locally and it failed. You can run the test locally by running

npm run test

One of the failed test is src/components/probe/prober/http/request.test.ts. You can run the failed test specifically by using

mocha --config .mocharc.json --forbid-only src/components/probe/prober/http/request.test.ts

I think the failed tests are blocking the github checks.

ok will do

@irwansyahwii
Copy link
Author

Hi @irwansyahwii, could you double check the test result? I ran the test locally and it failed. You can run the test locally by running

npm run test

One of the failed test is src/components/probe/prober/http/request.test.ts. You can run the failed test specifically by using

mocha --config .mocharc.json --forbid-only src/components/probe/prober/http/request.test.ts

I think the failed tests are blocking the github checks.

ok will do

Fixed

@irwansyahwii
Copy link
Author

The automated tests are not reliable. Sometimes it failed sometimes it succeed. Seems like there will be big architectural changes to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants