-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove axios package #1314
base: main
Are you sure you want to change the base?
Remove axios package #1314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @irwansyahwii, could you double check the test result? I ran the test locally and it failed. You can run the test locally by running
npm run test
One of the failed test is src/components/probe/prober/http/request.test.ts
. You can run the failed test specifically by using
mocha --config .mocharc.json --forbid-only src/components/probe/prober/http/request.test.ts
I think the failed tests are blocking the github checks.
ok will do |
Fixed |
The automated tests are not reliable. Sometimes it failed sometimes it succeed. Seems like there will be big architectural changes to fix it. |
Monika Pull Request (PR)
What feature/issue does this PR add
fetch
How did you implement / how did you fix it
httpClient
to prevent big changes on the client codesHow to test
npm run test