Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-besu): jest migrate get-transaction-endpoint #3621

Merged

Conversation

Udhayakumari
Copy link
Contributor

@Udhayakumari Udhayakumari commented Nov 7, 2024

Primary Changes:

packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/get-transaction-endpoint.test.ts

Fixes: #3539

Co-authored-by: Peter Somogyvari [email protected]

Signed-off-by: Udhayakumari [email protected]
Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Udhayakumari Thank you, looking good!
There is one required check failing but it looks like an infrastructure issue not something that the diff caused so I'll investigate that myself!

Primary Changes:

packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/get-transaction-endpoint.test.ts

Fixes: hyperledger-cacti#3539

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Udhayakumari <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz
Copy link
Contributor

petermetz commented Dec 4, 2024

@Udhayakumari Sorry for the slow response! I'm looking into this for you right now!
FYI: I'll resolve the merge conflicts that accumulated over time as well.

@petermetz petermetz force-pushed the get-transaction-endpoint branch from fcfb362 to f04845d Compare December 4, 2024 16:41
@petermetz petermetz requested a review from takeutak as a code owner December 4, 2024 16:41
@petermetz
Copy link
Contributor

@Udhayakumari The checks are passing now, the infrastructure related problems have been resolved, thank you for the contribution once again !

@petermetz petermetz merged commit 9ce00eb into hyperledger-cacti:main Dec 4, 2024
138 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(connector-besu): jest migrate get-transaction-endpoint.test.ts
3 participants