Update counter metrics for Txn handling

Signed-off-by: “Nithin <[email protected]>
hyperledger-labs · Mar 13, 2024 · e6d109b · e6d109b
1 parent ffc3866
commit e6d109b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 13 deletions.
diff --git a/src/main/java/hlf/java/rest/client/config/CustomTxnListenerMetricsConfig.java b/src/main/java/hlf/java/rest/client/config/CustomTxnListenerMetricsConfig.java
@@ -7,26 +7,26 @@
 import org.springframework.context.annotation.Configuration;
 
 @Configuration
-@ConditionalOnProperty("kafka.event-listener.brokerHost")
+@ConditionalOnProperty("kafka.integration-points[0].brokerHost")
 public class CustomTxnListenerMetricsConfig {
 
   @Bean
   public Counter customKafkaSuccessCounter(MeterRegistry meterRegistry) {
     return meterRegistry.counter("kafka.messages.processed.messages");
   }
 
-  @Bean
-  public Counter customKafkaFailureCounter(MeterRegistry meterRegistry) {
-    return meterRegistry.counter("kafka.messages.failed.messages");
-  }
-
   @Bean
   public Counter invalidInboundTransactionMessageCounter(MeterRegistry meterRegistry) {
-    return meterRegistry.counter("transaction.messages.unrecognized");
+    return meterRegistry.counter("transaction.messages.unrecognized.failures");
   }
 
   @Bean
   public Counter inboundTxnProcessingFailureCounter(MeterRegistry meterRegistry) {
     return meterRegistry.counter("transaction.messages.process.failures");
   }
+
+  @Bean
+  public Counter inboundTxnContractExceptionCounter(MeterRegistry meterRegistry) {
+    return meterRegistry.counter("transaction.messages.contract.failures");
+  }
 }
diff --git a/src/main/java/hlf/java/rest/client/metrics/EmitCustomTransactionListenerMetricsAspect.java b/src/main/java/hlf/java/rest/client/metrics/EmitCustomTransactionListenerMetricsAspect.java
@@ -5,24 +5,27 @@
 import org.aspectj.lang.ProceedingJoinPoint;
 import org.aspectj.lang.annotation.Around;
 import org.aspectj.lang.annotation.Aspect;
+import org.hyperledger.fabric.gateway.ContractException;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
 import org.springframework.stereotype.Component;
 
 @Aspect
 @Component
+@ConditionalOnProperty("kafka.integration-points[0].brokerHost")
 public class EmitCustomTransactionListenerMetricsAspect {
 
   private static final String ANNOTATION_NAME =
       "hlf.java.rest.client.metrics.EmitCustomTransactionListenerMetrics";
 
   @Autowired private Counter customKafkaSuccessCounter;
 
-  @Autowired private Counter customKafkaFailureCounter;
-
   @Autowired private Counter invalidInboundTransactionMessageCounter;
 
   @Autowired private Counter inboundTxnProcessingFailureCounter;
 
+  @Autowired private Counter inboundTxnContractExceptionCounter;
+
   @Around("@annotation(" + ANNOTATION_NAME + ")")
   public Object interceptedKafkaMetricsEmissionAdvice(ProceedingJoinPoint proceedingJoinPoint)
       throws Throwable {
@@ -33,14 +36,15 @@ public Object interceptedKafkaMetricsEmissionAdvice(ProceedingJoinPoint proceedi
       return returnValue;
     } catch (Throwable e) {
 
-      customKafkaFailureCounter.increment();
-
       if (e instanceof UnrecognizedTransactionPayloadException) {
         invalidInboundTransactionMessageCounter.increment();
-      } else {
-        inboundTxnProcessingFailureCounter.increment();
       }
 
+      if (e instanceof ContractException) {
+        inboundTxnContractExceptionCounter.increment();
+      }
+
+      inboundTxnProcessingFailureCounter.increment();
       throw e;
     }
   }