Introduce capability to get anchor peer nodes in a channel #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidhi-singh02
force-pushed
the
showAnchor
branch
2 times, most recently
from
fa6fff6
to
4f0716b
Compare
abhakish
reviewed
Feb 13, 2024
src/main/java/hlf/java/rest/client/service/impl/NetworkStatusImpl.java
Outdated
Show resolved
Hide resolved
nidhi-singh02
force-pushed
the
showAnchor
branch
from
4f0716b
to
0fababe
Compare
Signed-off-by: n0s09by <[email protected]>
nidhi-singh02
force-pushed
the
showAnchor
branch
from
0fababe
to
1f3e028
Compare
abhakish
approved these changes
Feb 15, 2024
| @Override | ||
| public ResponseEntity<ClientResponseModel> getAnchorPeerForChannel(String channelName) { | ||
| Network network = gateway.getNetwork(channelName); | ||
| Set<String> anchorPeersSet = new HashSet<>(); |
There was a problem hiding this comment.
[nitpick] declare just before where this Set will get used.
There was a problem hiding this comment.
Setting it here as it is getting used outside the try-catch blocks as well.
There was a problem hiding this comment.
you can return it directly from line # 107 instead of performing an assignment.
There was a problem hiding this comment.
Addressed, Thanks :)
src/main/java/hlf/java/rest/client/service/impl/NetworkStatusImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: n0s09by <[email protected]>
abhakish
reviewed
Feb 19, 2024
src/main/java/hlf/java/rest/client/controller/FabricOperationsController.java
Outdated
Show resolved
Hide resolved
nidhi-singh02
force-pushed
the
showAnchor
branch
4 times, most recently
from
ae8f289
to
82a0239
Compare
nithin-pankaj
approved these changes
Feb 20, 2024
| @Override | ||
| public ResponseEntity<ClientResponseModel> getAnchorPeerForChannel(String channelName) { | ||
| Network network = gateway.getNetwork(channelName); | ||
| Set<String> anchorPeersSet = new HashSet<>(); |
There was a problem hiding this comment.
you can return it directly from line # 107 instead of performing an assignment.
Signed-off-by: n0s09by <[email protected]>
nidhi-singh02
force-pushed
the
showAnchor
branch
from
82a0239
to
b23fe19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.