Add capabilities during org addition to channel #140
Conversation
Signed-off-by: Deepika Karanji - d0k03k3 <[email protected]>
| /** | ||
| * @param capabilities capabilities need to be added to config | ||
| * @return channel capabilities | ||
| */ | ||
| private Configtx.ConfigValue getCapabilities(String... capabilities) { | ||
| Configtx.ConfigValue.Builder valueBuilder = Configtx.ConfigValue.newBuilder(); | ||
| Configuration.Capabilities.Builder capabilitiesBuilder = | ||
| Configuration.Capabilities.newBuilder(); | ||
| valueBuilder.setModPolicy(DEFAULT_MOD_POLICY); | ||
| valueBuilder.setVersion(0); | ||
| for (String capability : capabilities) { | ||
| capabilitiesBuilder.putCapabilities( | ||
| capability, Configuration.Capability.newBuilder().build()); | ||
| } | ||
| valueBuilder.setValue(capabilitiesBuilder.build().toByteString()); | ||
| return valueBuilder.build(); | ||
| } |
There was a problem hiding this comment.
FabricChannelUtil is there for all the channel related code that is needed for channel creation and update, move this code and ChannelServiceImpl in that class and call that method in this class
There was a problem hiding this comment.
I note your point regarding moving thi function to FabricChannelUtil, but since the ChannelService class exists, its impl class should also exist and not be moved to a util in the context of this PR.
There was a problem hiding this comment.
I meant the duplicated code wrt getCapabilities in ChannelServiceImpl and your PR code, move it to FabricChannelUtil
| private static final String VALUE_TAG_CAPABILITIES = "Capabilities"; | ||
|
|
||
| private static final String FABRIC_2_0 = "V2_0"; | ||
|
|
||
| private static final String DEFAULT_MOD_POLICY = "Admins"; |
There was a problem hiding this comment.
Let's define the constants in FabricClientConstants and re-use. I see these constants being defined in other places like ChannelServiceImpl, could be picked from one place.
| System.out.println(user.getName()); | ||
| System.out.println(user.getRoles()); | ||
| System.out.println(user.getEnrollment()); |
There was a problem hiding this comment.
Remove these. If there is a valid reason to display these in the runtime trace, log it with DEBUG level
| * @param capabilities capabilities need to be added to config | ||
| * @return channel capabilities | ||
| */ | ||
| public Configtx.ConfigValue getCapabilities(String... capabilities) { |
There was a problem hiding this comment.
[nitpick] getCapabilitiesWithDefaultVersion
DeepikaKaranji
force-pushed
the
main
branch
2 times, most recently
from
65bcbb5 to
096e467
Compare
Signed-off-by: Deepika Karanji - d0k03k3 <[email protected]>
Add capabilities during org addition to channel