Update package dependencies: WAMR, WASI SDK, and parson #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelamelara
approved these changes
Jan 6, 2024
This is not quite as simple as expected. With our default configuration (LIBC on, WASI off) there are a couple errors in WAMR. Namely that os_is_handle_valid is not defined in sgx-platform.c and there is an include of libc_errno.h that appears to be outside the check for WASI includes. Changes were made to work around these problems. Namely we explicitly include the libc header & source. And we add a file that defines the missing function. Signed-off-by: Mic Bowman <[email protected]>
The WAMR upgrade enables an upgrade for WASI SDK. Needed to add definitions for a few additional symbols. Signed-off-by: Mic Bowman <[email protected]>
Update the parson library from https://github.com/kgabis/parson to version 1.5.3. Signed-off-by: Mic Bowman <[email protected]>
A couple of small fixes that affect behavior of contracts (these showed up with pdo-contracts tests): * make the default for '/' in a json string not to be escaped, this shows up in json encoding of keys * add __cxa_pure_function implementation that is missing from WASI SDK Signed-off-by: Mic Bowman <[email protected]>
cmickeyb
force-pushed
the
mic.jan04.wamr_update
branch
from
93b021d to
df1df6f
Compare
cmickeyb
changed the title
prakashngit
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not quite as simple as expected. With our
default configuration (LIBC on, WASI off) there are a couple errors in WAMR. Namely that os_is_handle_valid is not defined in sgx-platform.c and there is an include of libc_errno.h that appears to be outside the check for WASI includes.
Changes were made to work around these problems. Namely we explicitly include the libc header & source. And we add a file that defines the missing function.