Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SGX registration a bit more robust #480

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

g2flyer
Copy link
Contributor

@g2flyer g2flyer commented Mar 15, 2024

  • Handle missing SGX verification status CONFIGURATION_AND_SW_HARDENING_NEEDED
  • Honor PDO_LOG_LEVEL in registration script
  • Removes some misleading "ERROR" messages ...

Copy link
Member

@bvavala bvavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and necessary to support latest revision of IAS.

Ok to merge this before or after #477 .

Copy link
Contributor

@cmickeyb cmickeyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the final commit look good to me.

@cmickeyb
Copy link
Contributor

cmickeyb commented Apr 2, 2024

Good and necessary to support latest revision of IAS.

Ok to merge this before or after #477 .

definitely not before in its current form. the last commit of the three is the unique. the earlier ones are duplicates of 477 which have not yet been approved.

@g2flyer g2flyer force-pushed the msteiner.pr-477-fix branch 4 times, most recently from a8c434a to c343c7a Compare April 9, 2024 02:59
@g2flyer g2flyer force-pushed the msteiner.pr-477-fix branch from c343c7a to 7e5f682 Compare April 9, 2024 17:10
@g2flyer g2flyer marked this pull request as ready for review April 9, 2024 17:27
* Handle missing SGX verification status CONFIGURATION_AND_SW_HARDENING_NEEDED

Signed-off-by: Michael Steiner <[email protected]>
@g2flyer g2flyer force-pushed the msteiner.pr-477-fix branch from 7e5f682 to b174bf9 Compare April 9, 2024 17:31
* Make script PDO_LOG_LEVEL aware
* Remove unnecessary env check which leads to misleading ERROR messages
  when running no-config docker

Signed-off-by: Michael Steiner <[email protected]>
@g2flyer g2flyer force-pushed the msteiner.pr-477-fix branch from b174bf9 to 9300a3f Compare April 9, 2024 17:45
@bvavala bvavala merged commit b77ea21 into hyperledger-labs:main Apr 9, 2024
4 checks passed
@g2flyer g2flyer deleted the msteiner.pr-477-fix branch April 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants