Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-7742 Engine API Changes #7840

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

EIP-7742 Engine API Changes #7840

wants to merge 7 commits into from

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Oct 31, 2024 •
edited
Loading

PR description

Also block creation wiring was required in this PR in order to satisfy CodeDelegationTransactionAcceptanceTest

Part of #7605

Spec: ethereum/execution-apis#574

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

siladu
siladu commented Nov 1, 2024
View reviewed changes
...erge/src/main/java/org/hyperledger/besu/consensus/merge/blockcreation/PayloadIdentifier.java
.map(Withdrawal::hashCode)
.reduce(1, (a, b) -> a ^ (b * 31)))
.orElse(0)
<< 32
Copy link
Contributor Author

@siladu siladu Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, added a (<< 32) left shift for withdrawals to keep the hashcodes evenly distributed by using the same pattern as the other fields.

This change impacts the shanghai and cancun ATs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@siladu