Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes requirement of specific environment variables during testing #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removes requirement of specific environment variables during testing #108

wants to merge 1 commit into from

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Dec 12, 2024 •
edited
Loading

These environment KVM_SHOULD_BE_PRESENT HYPERV_SHOULD_BE_PRESENT variables just add unnecessary complexity, especially for newcomers who just cloned the repo. They're not very useful anyway

@ludfjig ludfjig added the enhancement New feature or request label Dec 12, 2024
@ludfjig ludfjig marked this pull request as ready for review December 12, 2024 18:24
@ludfjig ludfjig requested a review from simongdavies December 12, 2024 21:15
simongdavies
simongdavies requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@simongdavies simongdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit

src/hyperlight_host/src/sandbox/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simongdavies simongdavies simongdavies approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludfjig @simongdavies